Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/format: Merge Standard_D16as_v4 VM update #1187

Merged
merged 8 commits into from
Aug 12, 2020

Conversation

StephanTLavavej
Copy link
Member

Merge #1185 into feature/format so we can delete the old VMSS pool.

⚠️ Note to self: Commit this as a merge, not a squash!

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Aug 12, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 12, 2020 22:04
@barcharcraz
Copy link
Member

I think you should be able to fast forward feature/format at this point.

@StephanTLavavej
Copy link
Member Author

Unfortunately, by configuring the branch protection policy to prohibit developers from pushing non-reviewed commits, we've also prohibited fast-forward merges from being pushed. (I wonder whether we should be maintaining feature/format before any work has been pushed to it, but it's really been so little effort that I haven't brought it up.)

@CaseyCarter
Copy link
Member

I wonder whether we should be maintaining feature/format before any work has been pushed to it, but it's really been so little effort that I haven't brought it up.

We could simply wait until someone's ready to submit a PR, and then unlock the branch and fast-forward it. 🤷

@StephanTLavavej StephanTLavavej added the uncharted Excluded from the Status Chart label Aug 12, 2020
@StephanTLavavej StephanTLavavej merged commit 1125262 into feature/format Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation uncharted Excluded from the Status Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants