-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement views::empty and views::single range factories #1201
Conversation
// clang-format on | ||
|
||
_Semiregular_box& operator=(const _Semiregular_box& _That) noexcept(is_nothrow_copy_constructible_v<_Ty>&& | ||
is_nothrow_copy_assignable_v<_Ty>) /* strengthened */ requires copyable<_Ty> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That requires Claude here is quite hidden. I understand the pain of clang Format thought.
No change requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the requires-clause hidden in comparison to any other property of the function declaration that appears on these two lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it is just that we do not have many trailing requires clauses until recently.
So its more that we treat them differently that template constraints which come in a newline with an additional level of identation
...since I can't really justify the difference: the goal of constraints is not to be minimal!
@CaseyCarter This needs to be merged with recent commits. |
Thanks for completing yet another piece of the Ranges puzzle, and finding novel compiler bugs for the FE devs to fix! 😹 |
It's important to keep the compiler from overheating by ICEing it frequently. |
Partially addresses #39.