Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counted_iterator unwrapping bug #1213

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

CaseyCarter
Copy link
Member

As @BillyONeal always says, "If there are no tests the feature is broken." This apparently applies even to things we merged maybe a week ago.

@CaseyCarter CaseyCarter added the bug Something isn't working label Aug 20, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner August 20, 2020 02:20
@CaseyCarter CaseyCarter added the ranges C++20/23 ranges label Aug 20, 2020
@BillyONeal
Copy link
Member

Billy beats the test drum 🥁🥁🥁🥁🥁🥁🥁

@StephanTLavavej StephanTLavavej self-assigned this Aug 21, 2020
@StephanTLavavej StephanTLavavej merged commit 8ee6e65 into microsoft:master Aug 22, 2020
@StephanTLavavej
Copy link
Member

Thanks for this 🎁 - I am delighted that we can finally unwrap it! 😹

@CaseyCarter CaseyCarter deleted the ci_bug branch August 26, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ranges C++20/23 ranges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants