Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<yvals_core.h>: Updated _MSVC_STL_UPDATE to September 2020 #1272

Merged
merged 1 commit into from
Sep 16, 2020
Merged

<yvals_core.h>: Updated _MSVC_STL_UPDATE to September 2020 #1272

merged 1 commit into from
Sep 16, 2020

Conversation

Madhvan-Sharma
Copy link
Contributor

No description provided.

@Madhvan-Sharma Madhvan-Sharma requested a review from a team as a code owner September 5, 2020 10:11
@Madhvan-Sharma
Copy link
Contributor Author

#1257 solved

miscco
miscco approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and congratulations to your first submission

@CaseyCarter CaseyCarter linked an issue Sep 5, 2020 that may be closed by this pull request
<yvals_core.h>: Update _MSVC_STL_UPDATE to September 2020 #1257
Closed
@CaseyCarter CaseyCarter added the bug Something isn't working label Sep 5, 2020
@StephanTLavavej StephanTLavavej added enhancement Something can be improved and removed bug Something isn't working labels Sep 8, 2020
@StephanTLavavej
Copy link
Member

We'll be merging this soon - we have to merge PRs simultaneously on GitHub and our MSVC-internal repo, so we batch them up, and CppCon this week has kept us unusually busy!

@CaseyCarter CaseyCarter self-assigned this Sep 16, 2020
@CaseyCarter CaseyCarter merged commit 5a4f64b into microsoft:master Sep 16, 2020
@CaseyCarter
Copy link
Member

Thanks, and 🎉🎉🎉 congratulations on your first STL contribution! 🎉🎉🎉

@CaseyCarter CaseyCarter removed their assignment Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@miscco miscco miscco approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to September 2020
4 participants
@Madhvan-Sharma @StephanTLavavej @CaseyCarter @miscco