Azure Pipelines: Skip tests if build fails, run both tools even if other fails

[sylveon]

Fixes #1266

This adds basic build dependencies to the CI config. I've only added some basic dependencies to keep it simple, since the rest should eventually cascade to a build failure.

[BillyONeal]

High 5 for getting the best PR number possible.

[sylveon]

After making my other PR I just had to grab that number :P

Looks like steps don't support dependsOn, but I might be able to use condition instead, looking through the docs ATM.

[sylveon]

Conditions in steps won't really work because you can't verify if a specific step failed or not.

One idea that I have (at least for the validation stage) is to split it in 3 jobs:

• One that builds the tooling
• One that runs clang-format
• One that validates files

So that way, we can specify job dependencies normally. Same idea could be applied to the build & test jobs if each architecture is its own stage, rather than its own job.

[CaseyCarter]

Looks like this is Work in Progress? Shout if I'm wrong, or when you push some changes and it's ready for review.

[sylveon]

Yeah, but this is CI changes and IIRC draft PRs don't trigger CI, but since my changes are about CI...

[StephanTLavavej]

Makes sense - thanks for investigating this, and feel free to continue pushing commits to trigger the CI. (This PR will ultimately save us lots of resources when builds fail!)

[SuperWig]

draft PRs don't trigger CI

Unless that changed recently it should.

[CaseyCarter]

Yeah, but this is CI changes and IIRC draft PRs don't trigger CI, but since my changes are about CI...

That wasn't griping about making it a Draft PR - I can never remember if they trigger CI - just communicating my understanding of its status and choice of stage in https://github.com/microsoft/STL/projects/1. I wanted to ensure we're on the same page so you're not inadvertently left sitting here waiting for maintainer feedback.

[sylveon]

@CaseyCarter I believe this is ready for review!

Here's an example of a failing build that skips tests: https://dev.azure.com/vclibs/STL/_build/results?buildId=5335&view=results

I also squashed all my commits because testing CI is p a i n

[cbezault]

Sorry I made you throw away some of your work :(
LGTM now

[sylveon]

Haha it's fine I often throw away my work myself.

[StephanTLavavej]

Thanks for this significant infrastructure improvement - I think it'll improve the experience for contributors and decrease load on the VMSS which is awesome.

[CaseyCarter]

FYI, I'm about to merge this. If the CI stops working, I will likely snap my fingers Thanatos-style and destroy a significant portion of the universe.

[CaseyCarter]

Thanks for the contribution! (I'm 100% behind anyone-but-me enjoying the "edit-submit-wait an hour for CI" loop!)