Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated _MSVC_STL_UPDATE to October 2020 #1340

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

praveenojha33
Copy link
Contributor

Fixes #1338 : I have updated _MSVC_STL_UPDATE to October 2020

@praveenojha33 praveenojha33 requested a review from a team as a code owner October 2, 2020 20:01
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Oct 2, 2020
@CaseyCarter
Copy link
Member

Hi, Praveen! This looks great. Thanks!

@StephanTLavavej StephanTLavavej self-assigned this Oct 2, 2020
@StephanTLavavej StephanTLavavej merged commit 03ab954 into microsoft:master Oct 3, 2020
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🎉 😸 🚀

FYI - When we merged your PR, it appeared as co-authored by "praveenojha33 and Praveen Ojha". We've seen this happen before, so we know what causes this. What happened is that the commit that you pushed to your branch, which you used to create this PR, was tagged with an author email address that's different from whatever email address you've registered with GitHub.

You can fix this (which will be effective "retroactively", if you look at the microsoft/STL commit history) by registering an additional email address with GitHub. I've done this myself (as my GitHub account was created with my personal address, but I often push commits tagged with my work address). The process is:

  • Click on your avatar at the upper right of the screen
  • Click "Settings"
  • Click "Emails"
  • Use "Add email address".

Hope this helps!

@praveenojha33 praveenojha33 deleted the upd branch October 3, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to October 2020
3 participants