Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename _Iterator_base to _Category_base in <ranges> #1420

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Rename _Iterator_base to _Category_base in <ranges> #1420

merged 1 commit into from
Nov 7, 2020

Conversation

CaseyCarter
Copy link
Member

Fixes #1418.

@CaseyCarter CaseyCarter added enhancement Something can be improved ranges C++20/23 ranges labels Nov 3, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner November 3, 2020 19:50
miscco
miscco approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what its worth...

@mnatsuhara mnatsuhara self-assigned this Nov 4, 2020
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020
@StephanTLavavej
microsoftGH-1420 Rename _Iterator_base to _Category_base in <ranges>
21b6fe7
@StephanTLavavej StephanTLavavej self-assigned this Nov 5, 2020
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020
@StephanTLavavej
microsoftGH-1420 Rename _Iterator_base to _Category_base in <ranges>
9739f14
@StephanTLavavej StephanTLavavej merged commit 12a0e83 into microsoft:master Nov 7, 2020
@StephanTLavavej
Copy link
Member

Thanks for eliminating this shadowing! 🌞

@CaseyCarter CaseyCarter deleted the fix1418 branch November 9, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@miscco miscco miscco approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<ranges>: filter_view/transform_view::_Iterator_base shadowing
4 participants
@CaseyCarter @StephanTLavavej @miscco @mnatsuhara