Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<compare>: Improve floating-point spaceship CPO codegen #1475

Merged
merged 4 commits into from
Dec 1, 2020
Merged

<compare>: Improve floating-point spaceship CPO codegen #1475

merged 4 commits into from
Dec 1, 2020

Conversation

statementreply
Copy link
Contributor

Implements floating-point strong_order and weak_order without branching on the sign bit.

Also adds signaling NaN test cases, enabled on clang only (MSVC "quiets" signaling NaNs when constant evaluated).

@statementreply statementreply requested a review from a team as a code owner November 14, 2020 11:52
@StephanTLavavej StephanTLavavej added the performance Must go faster label Nov 15, 2020
@StephanTLavavej StephanTLavavej self-assigned this Nov 18, 2020
StephanTLavavej
StephanTLavavej reviewed Nov 21, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a great improvement - I will push fixes for a couple of comment typos but everything else looks like crystalline perfection to me. 💎

stl/inc/compare Outdated Show resolved Hide resolved
stl/inc/compare Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Nov 21, 2020
@statementreply
Copy link
Contributor Author

@StephanTLavavej I pushed fixes for comment typos after your approval.

@cbezault cbezault self-assigned this Nov 30, 2020
cbezault
cbezault approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@cbezault cbezault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty cool change. I got to learn a couple of ones' complement tricks today.

@StephanTLavavej StephanTLavavej merged commit cbd2b1c into microsoft:master Dec 1, 2020
@StephanTLavavej
Copy link
Member

Thanks for increasing the spaceship's speed - onward to Alpha Centauri! 🚀 🛸 🪐

@statementreply statementreply deleted the float_spaceship_cpo branch April 17, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@cbezault cbezault cbezault approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@statementreply @StephanTLavavej @cbezault