Downlevel standard coroutine support #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `<coroutine>` to be included if `_DOWNLEVEL_COROUTINES_SUPPORTED` is defined even if `__cpp_lib_coroutine` is not. Allows use of standard coroutines in C++14 and C++17 modes with a compiler that permits it. Comparison operators are explicitly defined instead of <=> in these modes. Corresponding compiler changes are expected to come in 16.10.
CaseyCarter
approved these changes
Mar 11, 2021
StephanTLavavej
requested changes
Mar 11, 2021
Add /permissive- to the /Zc:preprocessor config. Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
- Move detection of downlevel coroutines to yvals_core.h in definition of __cpp_lib_coroutine. - Rework inclusion of <coroutine> in terms of __cpp_lib_coroutine, guard <compare> inclusion and spaceship definition in _HAS_CXX20. - C++14-ify the coroutine test.
StephanTLavavej
approved these changes
Mar 12, 2021
|
Thanks for improving the past via time travel! 📅 🚀 🎉 😹 |
CaseyCarter
reviewed
Mar 12, 2021
| @@ -1296,6 +1292,10 @@ | |||
| #define __cpp_lib_shared_ptr_arrays 201611L // P0497R0 Fixing shared_ptr For Arrays | |||
| #endif // _HAS_CXX20 | |||
|
|
|||
| #if defined(__cpp_impl_coroutine) || defined(_DOWNLEVEL_COROUTINES_SUPPORTED) // TRANSITION, Clang coroutine support | |||
There was a problem hiding this comment.
Late feedback: We should remove the TRANSITION comment. Now that this is outside of _HAS_CXX20, this condition is permanent. I hate to make a PR for a single comment cleanup. @stl (Sorry!) @StephanTLavavej, do you have a "miscellaneous cleanups" branch laying around you could add this change to, or should I start one of my own?
There was a problem hiding this comment.
I had recorded a todo about the matching comment being out of date (too small to reset testing), I’ll add this to that list, and fix it when we’re done with deadlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
<coroutine>to be included if_DOWNLEVEL_COROUTINES_SUPPORTEDis defined even if
__cpp_lib_coroutineis not. Allows use of standardcoroutines in C++14 and C++17 modes with a compiler that supports it.
Comparison operators are explicitly defined instead of <=> in these
modes.
This mirrors the STL changes in internal MSVC-PR-309095.