Update the Standard Library Header Units test for attributes #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cdacamar just merged MSVC-PR-310951 "[modules] Persist standard C++ attributes" to fix DevCom-1160041 VSO-1180134 "Standard Library Header Units: deprecated attributes aren't imported". As expected, this causes the test's usage of
codecvt_mode::consume_headerto emit a deprecation warning:STL/stl/inc/codecvt
Line 27 in c5ee3b3
The fix is to silence the deprecation warning and remove the TRANSITION comment. This is consistent with the test coverage below for
<strstream>- we know we're exercising deprecated machinery.It's OK to apply this change to GitHub (which is using the latest public preview, 16.10 Preview 1) before picking up the compiler change - we can suppress a deprecation warning that isn't being emitted.