-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<chrono> [time.parse] #1768
<chrono> [time.parse] #1768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is amazing! I've reviewed the product code and (aside from nitpicks/typos that I'll push changes for), I have only 7 open questions - some about proposed stylistic improvements, and a couple about potential integer overflows. I'll resolve all of my comments except those open questions.
I'll review the test code tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed test code! Will push simple changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great! I pushed a one-line change to remove std::
qualification from numeric_limits
.
Thanks for taking the time to parse this Standardese into code! 😹 🚀 |
Also includes a minor update to
clock_cast
, to recognize thatsys_clock
can be converted directly to/fromutc_clock
, even though it doesn't haveto/from_utc
.