Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<chrono> [time.parse] #1768

Merged
merged 24 commits into from
Mar 26, 2021

Conversation

MattStephanson
Copy link
Contributor

Also includes a minor update to clock_cast, to recognize that sys_clock can be converted directly to/from utc_clock, even though it doesn't have to/from_utc.

@MattStephanson MattStephanson requested a review from a team as a code owner March 23, 2021 05:52
@MattStephanson MattStephanson changed the title [time.parse] <chrono> [time.parse] Mar 23, 2021
@StephanTLavavej StephanTLavavej added chrono C++20 chrono cxx20 C++20 feature labels Mar 23, 2021
@StephanTLavavej StephanTLavavej self-assigned this Mar 23, 2021
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is amazing! I've reviewed the product code and (aside from nitpicks/typos that I'll push changes for), I have only 7 open questions - some about proposed stylistic improvements, and a couple about potential integer overflows. I'll resolve all of my comments except those open questions.

I'll review the test code tomorrow.

stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
stl/inc/chrono Outdated Show resolved Hide resolved
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed test code! Will push simple changes.

Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! I pushed a one-line change to remove std:: qualification from numeric_limits.

@StephanTLavavej StephanTLavavej merged commit 027fc9f into microsoft:feature/chrono Mar 26, 2021
@StephanTLavavej
Copy link
Member

Thanks for taking the time to parse this Standardese into code! 😹 🚀

@MattStephanson MattStephanson deleted the time-parse branch September 8, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chrono C++20 chrono cxx20 C++20 feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants