Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2019 16.10 Preview 2 #1884

Merged
merged 6 commits into from
May 1, 2021

Conversation

StephanTLavavej
Copy link
Member

  • Update the toolset to VS 2019 16.10 Preview 2.
  • Change the Update Status Chart workflow to run for microsoft/STL only, as requested by @AdamBucior in Use GitHub Actions to update the Status Chart #1769. I've tested this in my fork.
    • This also increases the required node-version. It doesn't really matter (the workflow always retrieves the latest) but it's a new major version.
  • In the Standard Library Header Units test, use /exportHeader /headerName:angle and /headerUnit:angle (supported in Preview 2) to avoid the need for absolute paths.
  • Test vector's constexpr spaceships (supported in Preview 2), which fixes <vector>: Test constexpr spaceships #1677.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Apr 25, 2021
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 25, 2021 23:58
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate build systems, but the rest looks great

@fsb4000
Copy link
Contributor

fsb4000 commented Apr 26, 2021

In the Standard Library Header Units test, use /exportHeader /headerName:angle and /headerUnit:angle (supported in Preview 2) to avoid the need for absolute paths.

Great. I didn't know that. It works without absolute paths. Cool!

cl /EHsc /nologo /W4 /std:c++latest /MD  /exportHeader /headerName:angle iostream /Fo:iostream.obj
cl /EHsc /nologo /W4 /std:c++latest /MD  /exportHeader /headerName:angle vector /Fo:vector.obj
cl /EHsc /nologo /W4 /std:c++latest /MD /headerUnit:angle "iostream=iostream.ifc" /headerUnit:angle "vector=vector.ifc" main.cpp iostream.obj vector.obj

@mnatsuhara mnatsuhara removed their assignment Apr 30, 2021
@StephanTLavavej StephanTLavavej self-assigned this Apr 30, 2021
@StephanTLavavej StephanTLavavej merged commit 65eb507 into microsoft:main May 1, 2021
@StephanTLavavej StephanTLavavej deleted the vmss-diag-logs branch May 1, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<vector>: Test constexpr spaceships Build system: Codegen messages are noisy
5 participants