<chrono>: Allows the parsing of year + day-of-year to a time_point
#1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call to _Calculate_ymd should be sooner, so that parsed fields are converted to Gregorian YMD before we call _Apply_duration_fields.
StephanTLavavej
approved these changes
Jun 23, 2021
|
Thanks, looks great! I debugged through the test case in order to understand the control flow - really appreciate how you found exactly the right place to fix this. 😻 |
barcharcraz
approved these changes
Jun 26, 2021
|
Thanks again for fixing this bug (or, as the compiler backend devs say, "silent bad codegen")! 😸 🪲 📅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1938.
converted to Gregorian YMD before we call _Apply_duration_fields.