Use LWG-3518 to add noexcept
#2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to code that calls character trait operations. We already made this assumption at the vast majority of callsites, this simply adds the few I found when auditing.
36 tasks
CaseyCarter
commented
Jul 26, 2021
| @@ -698,7 +698,7 @@ constexpr size_t _Traits_rfind_ch(_In_reads_(_Hay_size) const _Traits_ptr_t<_Tra | |||
| template <class _Elem, bool = _Is_character<_Elem>::value> | |||
| class _String_bitmap { // _String_bitmap for character types | |||
| public: | |||
| constexpr bool _Mark(const _Elem* _First, const _Elem* const _Last) { | |||
| constexpr bool _Mark(const _Elem* _First, const _Elem* const _Last) noexcept { | |||
There was a problem hiding this comment.
Honestly, these four added noexcepts have nothing to do with LWG-3518 or character trait operations, I simply noticed in passing that they are do not emit exceptions when operating on character-like types.
StephanTLavavej
approved these changes
Jul 28, 2021
|
I'm going to add this to the next batch of changes to merge - please notify me if any further commits are pushed. |
barcharcraz
approved these changes
Jul 29, 2021
|
Thanks for looking into every LWG issue, no exceptions! 😹 🎉 🚀 |
Yes, this PR is truly 😃 ... 😎 exceptional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to code that calls character trait operations. We already made this assumption at the vast majority of callsites, this simply adds the few I found when auditing.
"Implements" LWG-3518.