Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rarely true check in char_traits::move #2083

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Remove rarely true check in char_traits::move #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions stl/inc/xstring
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ struct _Char_traits { // properties of a string or stream element
// If _First1 is in the src range, we need a backward loop.
// Otherwise, the forward loop works (even if the back of dest overlaps the front of src).

if (_First1 == _First2) {
return _First1; // Self-assignment; either loop would work, but returning immediately is faster.
}

// Usually, we would compare pointers with less-than, even though they could belong to different arrays.
// However, we're not allowed to do that during constant evaluation, so we need a linear scan for equality.
bool _Loop_forward = true;
Expand Down