Return _Nontrivial_dummy_type to <optional>
#2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pushed this type up into `<xutility>` to use implementing the `optional`-alikes in `<ranges>`. After realizing that the updated C++20 `constexpr` rules mean we can avoid activating any union alternative in a `constexpr` constructor if we like, we removed the uses in `<ranges>`. This PR simply moves the type back to `<optional>` since it's no longer used elsewhere.
CaseyCarter
changed the title
_Nontrivial_dummy_type to <optional>
miscco
approved these changes
Aug 12, 2021
fsb4000
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Approved.
But again:
##[error]We stopped hearing from agent BUILD0003C7. Verify the agent machine is running and has a healthy network
connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error.
For more information, see: https://go.microsoft.com/fwlink/?linkid=846610
:(
StephanTLavavej
approved these changes
Aug 12, 2021
StephanTLavavej
added
throughput
|
I'm mirroring this to an MSVC-internal PR. It's totally fine to push changes for code review feedback, but please notify me in that case. |
|
Thanks for cleaning up this tiny throughput issue! 🧹 🔬 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pushed this type up into
<xutility>to use implementing theoptional-alikes in<ranges>. After realizing that the updated C++20constexprrules mean we can avoid activating any union alternative in aconstexprconstructor if we like, we removed the uses in<ranges>. This PR simply moves the type back to<optional>since it's no longer used elsewhere.