Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fstream>: fstream::close shouldn't corrupt heap (after putback) #2189

Merged
merged 7 commits into from
Nov 3, 2021

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Sep 7, 2021

Fixes #342

@fsb4000 fsb4000 requested a review from a team as a code owner September 7, 2021 15:14
@CaseyCarter CaseyCarter changed the title <fstream>: fstream::close should'nt corrupt heap (after putback) <fstream>: fstream::close shouldn't corrupt heap (after putback) Sep 7, 2021
@CaseyCarter CaseyCarter added the bug Something isn't working label Sep 7, 2021
fsb4000 and others added 2 commits September 11, 2021 18:23
Co-authored-by: Alex Guteniev <gutenev@gmail.com>
@CaseyCarter CaseyCarter self-assigned this Sep 15, 2021
tests/std/test.lst Outdated Show resolved Hide resolved
tests/std/test.lst Outdated Show resolved Hide resolved
stl/inc/fstream Outdated Show resolved Hide resolved
Remove merge conflict markers from `tests/std/test.lst`
@CaseyCarter CaseyCarter assigned fsb4000 and unassigned CaseyCarter Oct 19, 2021
@StephanTLavavej StephanTLavavej removed their assignment Oct 23, 2021
@StephanTLavavej StephanTLavavej self-assigned this Nov 2, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ea54ea3 into microsoft:main Nov 3, 2021
@StephanTLavavej
Copy link
Member

Thanks for fixing this long-standing bug! 🗄️ 🐞 😸

@fsb4000 fsb4000 deleted the fix342 branch November 3, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<fstream>: Closing a filebuf after putback falls back to pbackfail leads to heap corruption
4 participants