Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<yvals_core.h> Remove unnecessary _HAS_CXX23 definition #2226

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

Atari2
Copy link
Contributor

@Atari2 Atari2 commented Oct 1, 2021

The symbol is already defined in <vcruntime.h> so it's redundant here.

Fixes #2214

@Atari2 Atari2 requested a review from a team as a code owner October 1, 2021 16:15
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your first contribution 🎉

stl/inc/yvals_core.h Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Oct 1, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 89f7204 into microsoft:main Oct 20, 2021
@StephanTLavavej
Copy link
Member

Thanks for removing this unnecessary code, and congratulations on your first microsoft/STL commit! 🎉 😸 🚀

This change will be available in VS 2022 17.1 Preview 2.

@Atari2 Atari2 deleted the remove_cxx23 branch October 20, 2021 10:16
AreaZR pushed a commit to AreaZR/STL that referenced this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Could definition of _HAS_CXX23 be removed?
7 participants