P2251R1 Update yvals_core.h and the comments in the tests #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ukilele
changed the title
CaseyCarter
requested changes
Oct 9, 2021
StephanTLavavej
approved these changes
Nov 10, 2021
CaseyCarter
approved these changes
Nov 10, 2021
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for updating the codebase for this C++23 feature! Your changes will ship in VS 2022 17.1 Preview 3. 🎉 😺 🚀 |
|
Hey, sorry that I neglected this PR. Thanks for finalizing it! |
|
No problem, and you're welcome! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2251
The according tests have already been there. Therefore I just mentioned P2251R1 in
yvals_core.hand updated some comments in the tests.