Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate bits using intrinsics #2369

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Conversation

AlexGuteniev
Copy link
Contributor

Resolves #2367

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner December 1, 2021 19:47
@CaseyCarter CaseyCarter added the performance Must go faster label Dec 1, 2021
@StephanTLavavej
Copy link
Member

Note: This contains a TRANSITION comment because cstdlib provides only 2 of the 4 intrinsics. We could file a followup issue to use the remaining intrinsics after updating intrin0.h.

@AlexGuteniev
Copy link
Contributor Author

Btw I confirm that clang-cl can use _rotl16 and _rotl8 and it doesn't mind moving the intrinsic from <intrin.h> elsewhere.

stl/inc/bit Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit db9cc55 into microsoft:main Dec 9, 2021
@StephanTLavavej
Copy link
Member

Thanks for increasing the STL's angular momentum! When things spin, science happens. ⚙️ 🌌 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<bit>: Implement rotl() and rotr() with intrinsics
6 participants