Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate reverse_copy optimization under C++20/C++23 mode #2416

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Activate reverse_copy optimization under C++20/C++23 mode #2416

merged 5 commits into from
Jan 19, 2022

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Dec 13, 2021 •
edited
Loading

Fixes #2415

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner December 13, 2021 17:12
@CaseyCarter CaseyCarter added the performance Must go faster label Dec 13, 2021
@StephanTLavavej StephanTLavavej self-assigned this Jan 12, 2022
@StephanTLavavej StephanTLavavej removed their assignment Jan 19, 2022
@StephanTLavavej
Copy link
Member

I searched for more occurrences of this problem, including through usage of related type traits, and didn't find any. 🎉

@StephanTLavavej StephanTLavavej self-assigned this Jan 19, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c616927 into microsoft:main Jan 19, 2022
@StephanTLavavej
Copy link
Member

Thanks for fixing this performance bug! 🚀 🐞 😸

@AlexGuteniev AlexGuteniev deleted the fix_reverse_copy_optimization branch January 20, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@miscco miscco miscco approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<algorithm>: reverse_copy optimization is not activated under C++20/C++23 mode
5 participants
@AlexGuteniev @StephanTLavavej @miscco @mnatsuhara @CaseyCarter