Use "int = 0" SFINAE in std::function to improve compiler throughput #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Looks good. No merge conflicts with #226 although they work towards the same goal.
|
We mess up clang-format sometimes too :P |
CaseyCarter
approved these changes
Nov 1, 2019
CaseyCarter
approved these changes
Nov 1, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephanTLavavej
approved these changes
Nov 1, 2019
|
Looks like this is ICEing the chk build of the compiler for now.... |
Clearly you are mistaken; the first post states "all tests pass":
|
|
You're telling me checking this box will fix all my build issues? Sign me up |
StephanTLavavej
requested changes
Nov 1, 2019
|
Cross-reference: this is related to #187. |
StephanTLavavej
changed the title
|
Should that also contain the fixes from @CaseyCarter concerning |
|
That’s a good question. @BillyONeal, I suspect that #248 is the same bug, so @miscco ’s idea of grouping them together should save time. #249 appears to be a different bug. |
Xiang Fan of the C1XX frontend team reported that this improved throughput in a customer submitted benchmark.
BillyONeal
force-pushed
the
function_on_off_sfinae
branch
from
15c172a
to
8e07b9b
Compare
CaseyCarter
approved these changes
Nov 27, 2019
StephanTLavavej
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use on/off SFINAE in std::function when not blocked by compiler bugs.
Xiang Fan of the C1XX frontend team reported that this improved throughput in a customer submitted benchmark.
Checklist
community PRs will be delayed until the test and CI systems are online.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.