Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups 1: Comments and formatting #2673

Merged

Conversation

StephanTLavavej
Copy link
Member

  • Detach comments.
    • This isn't attempting to be a global cleanup. Many of these will prevent the addition of _EXPORT_STD from causing wrapping, some fix wrapping that's already bad, some are for local consistency.
  • <string>: Remove unnecessary comments for to_string(), to_wstring(), and stoi() etc. - they're just repeating the function names.
    • A few (like stold()) would also cause wrapping with _EXPORT_STD.
  • <cstddef>: Remove SHOUTY RELICS and unnecessary comments, detach remaining comments.
  • <type_traits>: Comment _Refwrap_ctor_fun as // not defined.
  • <random>: Remove extra newline.
  • <random>: Unwrap string literals for assertions.
  • <xutility>: Shrink clang-format off region, add newline after declaring ranges::less.

@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Apr 27, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 27, 2022 20:38
@strega-nil-ms strega-nil-ms self-assigned this Apr 27, 2022
stl/inc/random Show resolved Hide resolved
@strega-nil-ms strega-nil-ms removed their assignment Apr 27, 2022
stl/inc/random Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Apr 28, 2022
@StephanTLavavej StephanTLavavej self-assigned this Apr 30, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit be47a3a into microsoft:main May 1, 2022
@StephanTLavavej StephanTLavavej deleted the cleanups-1-comments-formatting branch May 1, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants