-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups 1: Comments and formatting #2673
Merged
StephanTLavavej
merged 14 commits into
microsoft:main
from
StephanTLavavej:cleanups-1-comments-formatting
May 1, 2022
Merged
Cleanups 1: Comments and formatting #2673
StephanTLavavej
merged 14 commits into
microsoft:main
from
StephanTLavavej:cleanups-1-comments-formatting
May 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring ranges::less.
strega-nil-ms
approved these changes
Apr 27, 2022
CaseyCarter
approved these changes
Apr 28, 2022
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
raghavthind2005
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_EXPORT_STD
from causing wrapping, some fix wrapping that's already bad, some are for local consistency.<string>
: Remove unnecessary comments forto_string()
,to_wstring()
, andstoi()
etc. - they're just repeating the function names.stold()
) would also cause wrapping with_EXPORT_STD
.<cstddef>
: Remove SHOUTY RELICS and unnecessary comments, detach remaining comments.<type_traits>
: Comment_Refwrap_ctor_fun
as// not defined
.<random>
: Remove extra newline.<random>
: Unwrap string literals for assertions.<xutility>
: Shrinkclang-format off
region, add newline after declaringranges::less
.