Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0849R8 auto(x): decay-copy In The Language #2808

Merged
merged 2 commits into from
Jun 25, 2022

Conversation

StephanTLavavej
Copy link
Member

Fixes #2243. Thanks to @frederick-vs-ja and @CaseyCarter for analyzing the issue (see their comments there).

We implemented this in C++20 mode:

return _Val.begin();

return _Val.end();

return _Val.rbegin();

return _Val.rend();

While this is theoretically observable, it would require some effort to test, and the risk of damaging this is extremely low, so I have chosen the lazy kitty path of "comment the feature as done, then flop over". 🐈

@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Jun 21, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner June 21, 2022 03:24
@AlexGuteniev
Copy link
Contributor

AlexGuteniev commented Jun 21, 2022

Is the compiler part implemented?

@fsb4000
Copy link
Contributor

fsb4000 commented Jun 21, 2022

@AlexGuteniev no, compiler gives error C3537, at least in 17.3 Preview 2

@CaseyCarter CaseyCarter removed their assignment Jun 22, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jun 25, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit bb71d6c into microsoft:main Jun 25, 2022
@StephanTLavavej StephanTLavavej deleted the P0849R8 branch June 25, 2022 22:10
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx23 C++23 feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P0849R8 auto(x): decay-copy In The Language
6 participants