Prettify STL error output #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ``` PS ...\stl-tests> cl /Tc .\stl-warnings.cxx Microsoft (R) C/C++ Optimizing Compiler Version 19.33.31517 for x64 Copyright (C) Microsoft Corporation. All rights reserved. stl-warnings.cxx ...\yvals_core.h(23): fatal error C1189: #error: STL1003: Unexpected compiler, expected C++ compiler. ``` After ``` PS ...\stl-tests> cl /Tc .\stl-warnings.cxx Microsoft (R) C/C++ Optimizing Compiler Version 19.33.31517 for x64 Copyright (C) Microsoft Corporation. All rights reserved. stl-warnings.cxx ...\yvals_core.h(432): error STL1003: Unexpected compiler, expected C++ compiler. ...\yvals_core.h(432): error C2338: static_assert failed: 'Error in C++ Standard Library usage.' ```
strega-nil-ms
added
enhancement
|
Given that people generally seem happy with the idea of the changes, marking non-draft |
strega-nil-ms
removed
the
decision needed
|
Need to merge |
StephanTLavavej
requested changes
Jul 28, 2022
CaseyCarter
requested changes
Jul 29, 2022
CaseyCarter
approved these changes
Jul 29, 2022
strega-nil-ms
force-pushed
the
better-error-message
branch
from
1407b29
to
43c77f7
Compare
CaseyCarter
approved these changes
Jul 29, 2022
StephanTLavavej
approved these changes
Jul 30, 2022
|
@strega-nil-ms @CaseyCarter I've pushed a correctness fix, message appearance fix, and completed workaround removal - please double-check 😸 |
|
Thanks @StephanTLavavej, looks good to me :) |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Aug 3, 2022
|
Thanks for improving how these errors are displayed! ✨ 🎉 😺 |
strega-nil
added a commit
to strega-nil/stl
that referenced
this pull request
Aug 6, 2022
Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2896
Before:
After