Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map more Windows System errors #2899

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Map more Windows System errors #2899

merged 2 commits into from
Jul 28, 2022

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jul 23, 2022 •
edited by StephanTLavavej
Loading

Fixes #2893

System Error Codes (0-499)

  • ERROR_BAD_NET_NAME

    • 67 (0x43)
    • The network name cannot be found.

  • ERROR_FILENAME_EXCED_RANGE

    • 206 (0xCE)
    • The filename or extension is too long.

@fsb4000 fsb4000 requested a review from a team as a code owner July 23, 2022 03:56
@Morph1984
Copy link

Thank you for the quick fix!

@CaseyCarter CaseyCarter added enhancement Something can be improved affects redist Results in changes to separately compiled bits labels Jul 24, 2022
strega-nil-ms
strega-nil-ms reviewed Jul 25, 2022
View reviewed changes
stl/src/syserror.cpp Outdated Show resolved Hide resolved
@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej StephanTLavavej self-assigned this Jul 27, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit b491ec6 into microsoft:main Jul 28, 2022
@StephanTLavavej
Copy link
Member

Thanks for improving <system_error>'s behavior! 🎉 📈 😸

@fsb4000 fsb4000 deleted the fix2893 branch July 28, 2022 04:25
fsb4000 added a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@fsb4000
Map more Windows System errors (microsoft#2899)
8dccde0
@pdimov pdimov mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morph1984 Morph1984 Morph1984 left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
affects redist Results in changes to separately compiled bits enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<system_error>: Several Windows system errors are not mapped
5 participants
@fsb4000 @Morph1984 @strega-nil-ms @StephanTLavavej @CaseyCarter