Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LWG-3672: common_iterator::operator->() should return by value #2907

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

frederick-vs-ja
Copy link
Contributor

Towards #2872.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner July 25, 2022 04:08
... to fix test failures, match the existing comments, and avoid duplication.
@CaseyCarter CaseyCarter added LWG Library Working Group issue blocked Something is preventing work on this labels Jul 25, 2022
@CaseyCarter CaseyCarter added the ranges C++20/23 ranges label Jul 25, 2022
Co-authored-by: Casey Carter <cartec69@gmail.com>
@CaseyCarter CaseyCarter removed the blocked Something is preventing work on this label Jul 25, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jul 27, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9974091 into microsoft:main Jul 28, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing so many LWG issue resolutions and improving conformance! 😻 😻 😻 😻 😻 😻 😻

@frederick-vs-ja frederick-vs-ja deleted the lwg-3672 branch July 28, 2022 03:43
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
…value (microsoft#2907)

Co-authored-by: Casey Carter <cartec69@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants