Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3564: transform_view::iterator<true>::value_type and iterator_category should use const F& #2961

Merged
merged 11 commits into from
Aug 5, 2022
Merged

Implement LWG-3564: transform_view::iterator<true>::value_type and iterator_category should use const F& #2961

merged 11 commits into from
Aug 5, 2022

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #2951.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner July 28, 2022 05:56
@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges labels Jul 28, 2022
frederick-vs-ja
frederick-vs-ja commented Jul 28, 2022
View reviewed changes
stl/inc/ranges Outdated Show resolved Hide resolved
@strega-nil-ms strega-nil-ms self-assigned this Jul 28, 2022
strega-nil-ms
strega-nil-ms suggested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product code LGTM; the test needs some modification :)

tests/std/tests/P0896R4_views_transform/test.cpp Show resolved Hide resolved
miscco
miscco reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!

That said, I believe we can simplify the implementation a bit.

stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
@strega-nil-ms strega-nil-ms removed their assignment Jul 29, 2022
@StephanTLavavej StephanTLavavej self-assigned this Aug 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3e046a4 into microsoft:main Aug 5, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing all of these LWG issue resolutions - so much conformance! 😻 💯 🎉

@frederick-vs-ja frederick-vs-ja deleted the lwg-3564 branch August 5, 2022 23:58
strega-nil pushed a commit to strega-nil/stl that referenced this pull request Aug 6, 2022
@frederick-vs-ja @strega-nil
Implement LWG-3564: transform_view::iterator<true>::value_type and …
f9759e8 
…`iterator_category` should use `const F&` (microsoft#2961)
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@frederick-vs-ja @fsb4000
Implement LWG-3564: transform_view::iterator<true>::value_type and …
ebafd4e 
…`iterator_category` should use `const F&` (microsoft#2961)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@miscco miscco miscco approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3564 transform_view::_iterator_<true>::value_type and iterator_category should use const F&
5 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter @miscco @strega-nil-ms