Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P2494R2 Relaxing Range Adaptors To Allow Move-Only Types #2965

Merged
merged 14 commits into from
Aug 27, 2022
Merged

Implement P2494R2 Relaxing Range Adaptors To Allow Move-Only Types #2965

merged 14 commits into from
Aug 27, 2022

Conversation

strega-nil-ms
Copy link
Contributor

@strega-nil-ms strega-nil-ms commented Jul 28, 2022 •
edited
Loading

Fixes #2934

Needs test coverage

Blocked on #2661 (both update __cpp_lib_ranges)

@CaseyCarter CaseyCarter added ranges C++20/23 ranges cxx23 C++23 feature labels Jul 29, 2022
frederick-vs-ja
frederick-vs-ja reviewed Jul 29, 2022
View reviewed changes
stl/inc/ranges Outdated Show resolved Hide resolved
strega-nil-ms and others added 3 commits July 29, 2022 08:32
@strega-nil-ms @frederick-vs-ja
ups
aff6207 
Co-authored-by: A. Jiang <de34@live.cn>
@strega-nil
ahh, forgot the feature macro test
f0ec634
@strega-nil
add test
f405f2c
@strega-nil-ms strega-nil-ms marked this pull request as ready for review July 30, 2022 00:05
@strega-nil-ms strega-nil-ms requested a review from a team as a code owner July 30, 2022 00:05
@strega-nil
Make P2494R2 not a DR, and fix tests
d0d13ee 
WHY IS initializer_list NOT A VIEWABLE_RANGE
StephanTLavavej
StephanTLavavej requested changes Aug 2, 2022
View reviewed changes
tests/std/tests/P2494R2_move_only_range_adaptors/test.cpp Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Show resolved Hide resolved
stl/inc/ranges Show resolved Hide resolved
@strega-nil
Stephan CRs
8b8e978 
this also makes the tests better, imo
StephanTLavavej
StephanTLavavej requested changes Aug 2, 2022
View reviewed changes
stl/inc/ranges Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej reviewed Aug 2, 2022
View reviewed changes
stl/inc/ranges Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Aug 2, 2022
@StephanTLavavej
Copy link
Member

Thanks, this looks good! I pushed one last round of trivial nitpicks. Now we just need to merge the blocking PR.

@StephanTLavavej StephanTLavavej removed their assignment Aug 3, 2022
@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label Aug 3, 2022
@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Aug 22, 2022
@StephanTLavavej
Copy link
Member

This is now unblocked. 🎉

StephanTLavavej
StephanTLavavej reviewed Aug 23, 2022
View reviewed changes
tests/std/tests/P2494R2_move_only_range_adaptors/env.lst Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Aug 26, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

CaseyCarter
CaseyCarter approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue which I have a fix for. I've updated the issues for both P2321R2 an P2474R2 to indicate that their components have changes in P2494R2.

tests/std/tests/P2494R2_move_only_range_adaptors/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej merged commit 04e304b into microsoft:main Aug 27, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing this feature - now we can finally relax! 😹 🏖️ 🎉

@strega-nil-ms strega-nil-ms deleted the p2494 branch December 19, 2022 23:42
@tylerbrawl tylerbrawl mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2494R2 Relaxing Range Adaptors To Allow Move-Only Types
5 participants
@strega-nil-ms @StephanTLavavej @CaseyCarter @frederick-vs-ja @strega-nil