Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1899R3: views::stride #2981

Merged
merged 7 commits into from
Aug 7, 2022
Merged

P1899R3: views::stride #2981

merged 7 commits into from
Aug 7, 2022

Conversation

JMazurkiewicz
Copy link
Contributor

Implements P1899R3 - stride_view. Closes #2915.

Note(s)

@CaseyCarter CaseyCarter added ranges C++20/23 ranges cxx23 C++23 feature labels Aug 1, 2022
@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review August 1, 2022 21:30
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner August 1, 2022 21:30
@strega-nil-ms strega-nil-ms self-assigned this Aug 2, 2022
StephanTLavavej
StephanTLavavej requested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! Found a small number of issues, should be quick to address. 😸

tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp Outdated Show resolved Hide resolved
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
tests/std/tests/P1899R3_views_stride/test.cpp Outdated Show resolved Hide resolved
JMazurkiewicz and others added 2 commits August 5, 2022 12:51
@JMazurkiewicz @StephanTLavavej
Apply (some) suggestions from code review
9e47f4f 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@JMazurkiewicz
Apply more suggestions from code review
9869884 
* Rename `_Iterator_base` to `_Category_base`
* Swap `stride_view` constraints
* Fix `stride_view`'s iterator cross comparisons in tests (`ci <=> ci2` -> `i <=> ci2`)
@strega-nil-ms strega-nil-ms self-assigned this Aug 5, 2022
strega-nil-ms
strega-nil-ms reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the LWG issue we need to file, LGTM!

tests/std/tests/P1899R3_views_stride/test.cpp Outdated Show resolved Hide resolved
@JMazurkiewicz @strega-nil-ms
Apply even more suggestions from code review
483d2b2 
Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>
@StephanTLavavej StephanTLavavej self-assigned this Aug 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 7b5a482 into microsoft:main Aug 7, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing this C++23 feature and helping the STL make great strides in conformance! 😹 😻 🚀

@JMazurkiewicz JMazurkiewicz deleted the stride_view branch August 7, 2022 07:11
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 8, 2022
Merged
@JMazurkiewicz JMazurkiewicz mentioned this pull request Aug 9, 2022
Merged
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@JMazurkiewicz @StephanTLavavej
@strega-nil-ms @fsb4000
P1899R3: views::stride (microsoft#2981)
60d6ba6 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>
@JMazurkiewicz JMazurkiewicz mentioned this pull request Sep 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P1899R3 views::stride
4 participants
@JMazurkiewicz @StephanTLavavej @strega-nil-ms @CaseyCarter