<chrono>: chrono::abs incorrectly uses ?: with expressions that don't always have a common type
#2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by avoiding ill-formed uses of the conditional operator in `std::chrono::abs`. Fixes microsoft#2839
strega-nil-ms
approved these changes
Aug 3, 2022
Merged
CaseyCarter
changed the title
<chrono>: chrono::abs incorrectly uses ?: with expressions that don't always have a common type
StephanTLavavej
approved these changes
Aug 3, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for investigating and fixing this bug in time itself! 🕥 😹 🎉 |
strega-nil
pushed a commit
to strega-nil/stl
that referenced
this pull request
Aug 6, 2022
…s have a common type (microsoft#2988)
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
…s have a common type (microsoft#2988)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by avoiding ill-formed uses of the conditional operator in
std::chrono::abs.Fixes #2839