-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tests/P1206R7_ranges_to
into four parts
#3026
Conversation
,... to reduce resource consumption. The obvious approach here is to split the three big pieces (the `sequence_instantiator`, `mappish_instantiator`, and `settish_instantiator` tests) each into their own tests, leaving behind the three small pieces (`test_reservable`, `test_common_constructible`, and `test_nested_range`). Fun fact: there are now 50 `P1206R7` tests in the `std` suite.
I think this was purely code-shifting, so diffing each of the four new tests with the old I did also cleanup the includes a bit, adding |
Diffing against the original test was indeed very easy, thanks for avoiding other code movement! I pushed changes to fix a stealth merge conflict and one moved test line that was revealed by the diff. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
I've pushed a conflict-free merge to resolve the conflict with #3015 ( |
2️⃣ ➕ 2️⃣ |
,... to reduce resource consumption. The obvious approach here is to split the three big pieces (the
sequence_instantiator
,mappish_instantiator
, andsettish_instantiator
tests) each into their own tests, leaving behind the three small pieces (test_reservable
,test_common_constructible
, andtest_nested_range
).Fun fact: there are now 50
P1206R7
tests in thestd
suite.