Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<yvals_core.h> Update P2549 to new revision #3075

Merged
merged 1 commit into from
Sep 13, 2022
Merged

<yvals_core.h> Update P2549 to new revision #3075

merged 1 commit into from
Sep 13, 2022

Conversation

killerswin2
Copy link
Contributor

@killerswin2 killerswin2 commented Sep 4, 2022 •
edited
Loading

What have you changed and why?

Information:
Changes yval_core.h to have the "correct" revision number

Specify which Issue this PR Resolves.

closes #2873
closes #2940

@killerswin2 killerswin2 requested a review from a team as a code owner September 4, 2022 02:10
fsb4000
fsb4000 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@fsb4000 fsb4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also add closes #2940

@killerswin2
Copy link
Contributor Author

I think you should also add closes #2940

Can do

@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Sep 5, 2022
@StephanTLavavej StephanTLavavej self-assigned this Sep 12, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej changed the title <yvals_core.h> Update 2549 to new revision <yvals_core.h> Update P2549 to new revision Sep 13, 2022
@StephanTLavavej StephanTLavavej merged commit cade0a7 into microsoft:main Sep 13, 2022
@StephanTLavavej
Copy link
Member

Thanks for updating this paper citation, and congratulations on your first microsoft/STL commit! 🚀 🎉 😻

@killerswin2
Copy link
Contributor Author

Aw-shucks, thanks for the warm welcome.

CaseyCarter pushed a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
@killerswin2 @CaseyCarter
<yvals_core.h> Update P2549 to new revision (microsoft#3075)
0f170e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2549R1 unexpected<E>::error() <yvals_core.h>: Update the reference to P2549 to P2549R1
5 participants
@killerswin2 @StephanTLavavej @CaseyCarter @fsb4000 @frederick-vs-ja