Tools: python script cleanups (functionality unchanged)

[BrandonPacewic]

Aligning the python scripts closer to the PEP-8 style guide & some other cleanups.

Functionality is completely unchanged, these suggestions are purely formatting and readability updates. Hopefully bringing some of this code closer to the incredible standards maintained by this team.

[strega-nil-ms]

This seems absolutely reasonable to me; I do like the type annotations. Otherwise, I don't personally have a lot of investment in following PEP-8 for our code, but also I don't mind following it either.

[barcharcraz]

Like nicole I don't really care about pep8 (and, in fact, I find it can sometimes have too many rules), but this seems OK to me.

Type annotations are always good, though I mostly use them just for the tooling support.

[BrandonPacewic]

Otherwise, I don't personally have a lot of investment in following PEP-8 for our code, but also I don't mind following it either.

Like nicole I don't really care about pep8 (and, in fact, I find it can sometimes have too many rules), but this seems OK to me.

I agree, following pep8 strictly isn't the best (especially with so many rules). Mainly just wanted to increase consistency.

[StephanTLavavej]

Thanks for this cleanup! I wanted to use f-strings when I wrote print_failures.py but didn't know how to deal with the nested quotes (since I'm a Python novice), so I'm glad you've shown us how to. There's an issue with the CRLF replacement - I don't know if that line needs to be reverted, or if it can be adjusted to keep the f-string improvement.

[BrandonPacewic]

My mistake for not double checking the backslash problem with f-strings, I have reverted that change for now. The other option would be something like this:

my_string = f"This is a backslash: {chr(92)}"

92 being the ASCII code for a backslash \. With the final product being something like this:

print(f"output: {result['output'].replace(f'{chr(92)}r{chr(92)}n', f'{chr(92)}n')}")

Definitely not the best solution but seems to be necessary to get away from .format() currently.

[StephanTLavavej]

✅ No C++, so no modules impact! 😸

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[StephanTLavavej]

Thanks for improving these scripts - and congratulations on your first microsoft/STL commit! 🎉 😸 🐍

[BrandonPacewic]

Thanks for improving these scripts - and congratulations on your first microsoft/STL commit! 🎉 😸 🐍

🎉🚀🎉