Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2404R3: Move-Only Types For Comparison Concepts #3345

Merged
merged 7 commits into from
Jan 28, 2023
Merged

P2404R3: Move-Only Types For Comparison Concepts #3345

merged 7 commits into from
Jan 28, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Jan 12, 2023 •
edited
Loading

Closes #2924.

This PR adds support for move-only types to C++20 concepts: three_way_comparable_with, equality_comparable_with and totally_ordered_with.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner January 12, 2023 22:09
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Jan 12, 2023
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this Jan 24, 2023
strega-nil-ms
strega-nil-ms suggested changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! Just that minor change in yvals_core.h requested :)

stl/inc/concepts Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Jan 25, 2023
@StephanTLavavej
Copy link
Member

Thanks, looks great! I pushed changes to fix the paper citation for C++20 concepts, and ultra-minor test nitpicks. FYI @strega-nil-ms.

@StephanTLavavej StephanTLavavej self-assigned this Jan 27, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1da3178 into microsoft:main Jan 28, 2023
@StephanTLavavej
Copy link
Member

Thanks for implementing this C++23 feature and improving these concepts! 🚀 😻 🎉

@JMazurkiewicz JMazurkiewicz deleted the mocmp branch January 28, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2404R3 Move-Only Types For Comparison Concepts
3 participants
@JMazurkiewicz @StephanTLavavej @strega-nil-ms