stl/CMakeLists.txt: Fix add_compile_options() ordering

[StephanTLavavej]

Our ASM_MASM options were being ignored (!) because they appeared after add_library(). This was visible in the output because /nologo was missing, we just didn't notice. (See output below.) This regression happened in #2780.

To fix this and prevent any recurrence, I'm slightly reorganizing this file. First, I'm introducing 3 prominent box comments, dividing the file into clear sections. The actual fix is to move add_compile_options() up. Finally, I'm moving add_compile_definitions() down slightly, so that the compile definitions, compile options, and include directories are grouped together.

I've additionally verified the fix by looking at the verbose build output; our desired options are now being passed to MASM.

Before

D:\GitHub\STL>ninja -C out\x64
ninja: Entering directory `out\x64'
[1/1014] Building ASM_MASM object stl\CMakeFiles\stl_alias_objects.dir\src\alias_init_once_begin_initialize.asm.obj
Microsoft (R) Macro Assembler (x64) Version 14.35.32213.0
Copyright (C) Microsoft Corporation.  All rights reserved.

 Assembling: D:\GitHub\STL\stl\src\alias_init_once_begin_initialize.asm
[2/1014] Building ASM_MASM object stl\CMakeFiles\stl_alias_objects.dir\src\alias_init_once_complete.asm.obj
Microsoft (R) Macro Assembler (x64) Version 14.35.32213.0
Copyright (C) Microsoft Corporation.  All rights reserved.

 Assembling: D:\GitHub\STL\stl\src\alias_init_once_complete.asm
[1014/1014] Linking CXX static library out\lib\amd64\libcpmtd0.lib

After

D:\GitHub\STL>ninja -C out\x64
ninja: Entering directory `out\x64'
[1/1014] Building ASM_MASM object stl\CMakeFiles\stl_alias_objects.dir\src\alias_init_once_complete.asm.obj
 Assembling: D:\GitHub\STL\stl\src\alias_init_once_complete.asm
[2/1014] Building ASM_MASM object stl\CMakeFiles\stl_alias_objects.dir\src\alias_init_once_begin_initialize.asm.obj
 Assembling: D:\GitHub\STL\stl\src\alias_init_once_begin_initialize.asm
[1014/1014] Linking CXX static library out\lib\amd64\libcpmtd0.lib

Note

I've implemented a /quiet option for MASM in VS 2022 17.7 Preview 1 that will allow the "Assembling" messages to be suppressed, making the output here ideal - that's how I discovered this.

[strega-nil-ms]

Thanks for the changes! Approve once suggestions are complete.

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.