-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2609R3: Relaxing Ranges Just A Smidge #3486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMazurkiewicz
commented
Feb 20, 2023
CaseyCarter
requested changes
Feb 20, 2023
tests/std/tests/P2609R3_relaxing_ranges_just_a_smidge/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/P2609R3_relaxing_ranges_just_a_smidge/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
With assumption that we don't need `int main() {} // COMPILE-ONLY` anymore thanks to microsoft#3484
This comment was marked as outdated.
This comment was marked as outdated.
CaseyCarter
approved these changes
Feb 20, 2023
strega-nil-ms
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
StephanTLavavej
approved these changes
Feb 21, 2023
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for implementing this C++23 feature - now we can relax! 🏖️ 🎮 📖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3441.
Drive-by: reduced clang-format suppressed regions.