Cleanups: #undef macro hygiene
#3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used entirely within __msvc_sanitizer_annotate_container.hpp and undef'ed there.
StephanTLavavej
added
enhancement
strega-nil-ms
approved these changes
Mar 6, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<fstream>defines_FSTREAM_SUPPORTS_EXPERIMENTAL_FILESYSTEMand is the only consumer of it. We should#undefit when we're done.#undefit in that case.<vector>shouldn't#undef _ACTIVATE_VECTOR_ANNOTATION.<__msvc_sanitizer_annotate_container.hpp>which unconditionally#undefs it at the end:STL/stl/inc/__msvc_sanitizer_annotate_container.hpp
Line 75 in 16bb556
<xstring>: Like<vector>, we should#undef_ASAN_STRING_MEOWand_INSERT_STRING_ANNOTATION._ASAN_STRING_MEOWis defined by<xstring>and used nowhere else._INSERT_STRING_ANNOTATIONis defined by<__msvc_sanitizer_annotate_container.hpp>, used by it and<xstring>and then nowhere else.