Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a dozen PRs with changes grouped according to various themes for ease of reviewing. This is the remaining grab bag 😹 where it would be unproductive to decompose further. These changes are all targeted and simple.
if
-statement inppltasks.cpp
.if
-statement being preprocessor-controlled.this->
when callingBase::meow()
.this->
when reaching into dependent base classes. These cases are different because we're calling identically-named functions in the base class.)_STL_INTERNAL_STATIC_ASSERT
ininvoke()
.static_assert
machinery. As"bug in invoke"
indicated, if this ever activated, it would indicate an STL implementation bug, not bogus programmer-user inputs.#include _STL_INTRIN_HEADER
to the end so it doesn't interrupt clang-format sorting.src/xmtx.hpp
doesn't need push-pop defenses.src
-internal headers have or need them.xmath.hpp
andxmtx.hpp
should behave like the othersrc
-internal headers and rely on#pragma once
instead of idempotency macros.xmath.hpp
was user-visible a while ago, andxmtx.hpp
might have been too, which would explain their different styles._Pass_fn()
as_NODISCARD
._Ryu_exponent
can beconst
._Can_const_join
workaround and_As_lvalue()
up, to avoid separatingjoin_view
's primary template and specialization.