Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<iterator>: reduced parsing time #355

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Commits on Dec 7, 2019

  1. <iterator>: reduced parsing time

    * Replaced `<istream>` include with `<iosfwd>` because `[io]stream_iterator`
      needs only `basic_[io]stream` forward declaration.
    * Moved `[io]streambuf_iterator` iterator definition to `<iterator>` because
      their definition has to come when `<iterator>` is included.
    * Include `<iterator>` in `<xlocmon>`, `<xlocnum>`, and `<xloctime>` as
      the `[io]streambuf_iterator` definition are required there, and `<xutility>`
      already included via other includes.
    
    Parsing times:
    
    | header     |          clang          |           msvc          |
    |------------|-------------------------|-------------------------|
    | <iterator> | 0.371 -> 0.163 (-56.1%) | 0.216 -> 0.094 (-56.5%) |
    | <istream>  | 0.366 -> 0.372 ( +1.6%) | 0.215 -> 0.216 ( +0.5%) |
    | <xlocmon>  | 0.358 -> 0.364 ( +1.7%) | 0.211 -> 0.211 (    0%) |
    | <xlocnum>  | 0.357 -> 0.360 ( +0.8%) | 0.207 -> 0.208 ( +0.5%) |
    | <xloctime> | 0.364 -> 0.370 ( +1.6%) | 0.211 -> 0.214 ( +1.4%) |
    Kojoley committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    1f264b4 View commit details
    Browse the repository at this point in the history