Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vector_algorithms.cpp: Add vzeroupper, so that it is there even in /Od #3630

Merged
merged 2 commits into from
Apr 7, 2023
Merged

vector_algorithms.cpp: Add vzeroupper, so that it is there even in /Od #3630

merged 2 commits into from
Apr 7, 2023

Conversation

AlexGuteniev
Copy link
Contributor

Fix #3601

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner April 6, 2023 14:29
@StephanTLavavej StephanTLavavej added the performance Must go faster label Apr 6, 2023
@StephanTLavavej StephanTLavavej changed the title vector_algorithms.cpp: Add vzeroupper, so that is is there even in /Od vector_algorithms.cpp: Add vzeroupper, so that it is there even in /Od Apr 6, 2023
StephanTLavavej
StephanTLavavej reviewed Apr 6, 2023
View reviewed changes
stl/src/vector_algorithms.cpp Outdated Show resolved Hide resolved
stl/src/vector_algorithms.cpp Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Thanks! 😻 I verified that all occurrences of _Use_avx2() have been updated, and that the guard type is used if and only if an early return is possible. FYI @strega-nil-ms I pushed a small commit to enhance the guard type after you approved (no functional change, just resists future misuse).

@StephanTLavavej StephanTLavavej mentioned this pull request Apr 6, 2023
Closed
@StephanTLavavej StephanTLavavej self-assigned this Apr 7, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit e6a12f7 into microsoft:main Apr 7, 2023
@StephanTLavavej
Copy link
Member

Thanks for comprehensively fixing this performance issue! 🛠️ 🚀 ✅

@AlexGuteniev AlexGuteniev deleted the vzeroupper branch April 8, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<algorithm>: vectorized algorithms hurt performance.
3 participants
@AlexGuteniev @StephanTLavavej @strega-nil-ms