Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<optional>: Fix exception specification for optional's transform-construction #3668

Merged
merged 9 commits into from
Apr 28, 2023
Merged

<optional>: Fix exception specification for optional's transform-construction #3668

merged 9 commits into from
Apr 28, 2023

Commits on Apr 24, 2023

  1. Fix exception specification for transform-construction of optional

    @frederick-vs-ja
    frederick-vs-ja authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    38e7bf9 View commit details
    Browse the repository at this point in the history

  2. Add test coverage

    @frederick-vs-ja
    frederick-vs-ja authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    83022ea View commit details
    Browse the repository at this point in the history

  3. Include <exception> for exception

    @frederick-vs-ja
    frederick-vs-ja authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    fa13be6 View commit details
    Browse the repository at this point in the history

  4. Clang-format

    @frederick-vs-ja
    frederick-vs-ja authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    43e9019 View commit details
    Browse the repository at this point in the history

  5. Missed replacing!

    @frederick-vs-ja
    frederick-vs-ja authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    ff46f66 View commit details
    Browse the repository at this point in the history

  6. Handle warning C4702

    @frederick-vs-ja
    frederick-vs-ja authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    2761494 View commit details
    Browse the repository at this point in the history

  7. Adopt @cpplearner's review comments 

    making the exception specification consistent with `expected`

Co-authored-by: S. B. Tam <cpplearner@outlook.com>
    @frederick-vs-ja @cpplearner
    frederick-vs-ja and cpplearner authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    7075dd9 View commit details
    Browse the repository at this point in the history

  8. Nitpicks: Add underscore and comment.

    @StephanTLavavej
    StephanTLavavej committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    94df21e View commit details
    Browse the repository at this point in the history

  9. Test both trivial and non-trivial dtors.

    @StephanTLavavej
    StephanTLavavej committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    8bbf980 View commit details
    Browse the repository at this point in the history