Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<utility> Deprecate std::rel_ops & resolve #403 #402

Merged
merged 9 commits into from
Jan 9, 2020

Conversation

SuperWig
Copy link
Contributor

@SuperWig SuperWig commented Dec 21, 2019

Description

Just another check box to tick for #64

Perhaps "the std::rel_ops operators are deprecated..." is better?

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@SuperWig SuperWig requested a review from a team as a code owner December 21, 2019 12:39
@AdamBucior
Copy link
Contributor

I think you should also deprecate namespace, so if someone uses using namespace std::rel_ops; he receives the warning.

@SuperWig
Copy link
Contributor Author

@AdamBucior I didn't realise that was a thing. 👍

Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few mechanical changes, and I'm sure we'll all want to bicker about the text of the deprecation message.

stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/utility Outdated Show resolved Hide resolved
Co-Authored-By: Casey Carter <cartec69@gmail.com>
@SuperWig SuperWig force-pushed the rel_ops branch 3 times, most recently from 3d7e6a7 to 41004ec Compare December 22, 2019 09:49
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SuperWig SuperWig changed the title <utility> Deprecate std::rel_ops <utility> Deprecate std::rel_ops & resolve #403 Jan 7, 2020
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BillyONeal BillyONeal self-assigned this Jan 8, 2020
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@BillyONeal
Copy link
Member

Thanks for your contribution!

@BillyONeal BillyONeal merged commit 48c7f31 into microsoft:master Jan 9, 2020
@SuperWig SuperWig deleted the rel_ops branch February 4, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants