Remove STL workarounds for VSO-1006185 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which has been fixed for 16.6p1. Fixes microsoft#416.
|
Blocked on release of Visual Studio 2019 16.6 Preview 1. |
StephanTLavavej
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Looks good to me. Remember that there are workarounds in devcrt too (3 occurrences in Dev11_1140665_unique_ptr_array_conversions); depending on when we can migrate devcrt to GitHub, you'll either need to update this PR, or add Microsoft-internal test changes.
StephanTLavavej
approved these changes
Jan 9, 2020
StephanTLavavej
added
blocked on VS 2019 16.6 Preview 1
and removed
blocked
StephanTLavavej
approved these changes
Mar 18, 2020
BillyONeal
approved these changes
Mar 18, 2020
The tests hadn't made it into the OSS repo when this PR was created.
StephanTLavavej
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...which has been fixed for 16.6p1.
Fixes #416.
[This is a dual of internal PR MSVC-PR-222093.]
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.