Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #345: Remove warning C4265 (non-virtual destructor) suppressions. #452

Merged

Conversation

StephanTLavavej
Copy link
Member

Description

Now that VS 2019 16.5 Preview 2 is available, we can fix #345 by removing warning suppressions where the compiler won't warn anymore. The suppressions for external code in WRL are still necessary.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner January 24, 2020 08:05
@StephanTLavavej StephanTLavavej self-assigned this Jan 24, 2020
@StephanTLavavej StephanTLavavej merged commit 125df9b into microsoft:master Jan 24, 2020
@StephanTLavavej StephanTLavavej deleted the fix_gh_345_warning_c4265 branch January 24, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STL: Remove warning C4265 (non-virtual destructor) suppressions
3 participants