Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the tr1 test suite. #485

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Conversation

StephanTLavavej
Copy link
Member

Description

Works towards #144. Note that this is just the source code; the infrastructure to automatically build and run the tests is coming soon.

Update enforce-clang-format.cmd as parallelize is recursive. (I verified that behavior by running parallelize directly.) We don't need to mention stl/inc's subdirectories. We can mention all of tools because clang-format detects file extensions and the other files in tools are fine. (In contrast, excluding stl/msbuild saves time.) Finally, add tests/tr1 (which is why we depend on recursive behavior, due to its many subdirectories). Also, update the git status and git diff commands to print differences in the tests directory too.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

Works towards microsoft#144. Note that this is just the source code; the
infrastructure to automatically build and run the tests is coming soon.

Update enforce-clang-format.cmd as parallelize is recursive. (I verified
that behavior by running parallelize directly.) We don't need to mention
stl/inc's subdirectories. We can mention all of tools because
clang-format detects file extensions and the other files in tools are
fine. (In contrast, excluding stl/msbuild saves time.) Finally, add
tests/tr1 (which is why we depend on recursive behavior, due to its many
subdirectories). Also, update the git status and git diff commands to
print differences in the tests directory too.
@StephanTLavavej StephanTLavavej added the test Related to test code label Feb 6, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 6, 2020 02:53
@StephanTLavavej StephanTLavavej self-assigned this Feb 6, 2020
@StephanTLavavej StephanTLavavej merged commit 30031d3 into microsoft:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants