Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt LWG-3390 #567

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Adopt LWG-3390 #567

merged 1 commit into from
Feb 29, 2020

Conversation

Svido
Copy link
Contributor

@Svido Svido commented Feb 28, 2020

Fixes #547

Description

Adopting LWG-3390.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@Svido Svido requested a review from a team as a code owner February 28, 2020 18:43
@BillyONeal
Copy link
Member

Can you add tests for this?

@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Feb 28, 2020
@Svido
Copy link
Contributor Author

Svido commented Feb 28, 2020

Can you add tests for this?
Sure. Where is the best place to add the tests?

@BillyONeal
Copy link
Member

Can you add tests for this?
Sure. Where is the best place to add the tests?

Normally:

  1. grep somewhere in tests/std for a test already testing close to what you're testing and insert into there where it makes sense
  2. if there are no good candidates, add a new test by:

Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I'll merge this to the Microsoft-internal repo. I don't think that we need specific test changes for this - testing should be added for WG21-P1207 as part of completing #39.

@StephanTLavavej StephanTLavavej self-assigned this Feb 29, 2020
@StephanTLavavej StephanTLavavej merged commit 51b212a into microsoft:master Feb 29, 2020
@StephanTLavavej
Copy link
Member

Thanks again! Now we're closer to zero LWG issues remaining :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LWG-3390 make_move_iterator() cannot be used to construct a move_iterator for a move-only iterator
4 participants