Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored some for loops to normal pattern. #709

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Refactored some for loops to normal pattern. #709

merged 2 commits into from
Apr 22, 2020

Conversation

babhishek21
Copy link
Contributor

Fixes #678. I've mentioned some other cases I found in the issue.

@babhishek21 babhishek21 requested a review from a team as a code owner April 12, 2020 10:21
@msftclas
Copy link

msftclas commented Apr 12, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@CaseyCarter CaseyCarter added the enhancement Something can be improved label Apr 13, 2020
CaseyCarter
CaseyCarter requested changes Apr 13, 2020
View reviewed changes
stl/inc/random Show resolved Hide resolved
@BillyONeal
Copy link
Member

I have never seen any problematic code identified by this warning

You are so lucky then :P

@StephanTLavavej StephanTLavavej self-assigned this Apr 21, 2020
@StephanTLavavej
Copy link
Member

After @CaseyCarter approves, I'll mirror this to the Microsoft-internal repo in preparation for merging. Thanks!

@StephanTLavavej StephanTLavavej merged commit b766470 into microsoft:master Apr 22, 2020
@StephanTLavavej
Copy link
Member

Thanks for this consistency improvement, and congratulations on your first microsoft/STL commit! 😸

@SuperWig SuperWig mentioned this pull request Apr 22, 2020
Merged
4 tasks
@babhishek21 babhishek21 deleted the use_normal_for_loops branch April 22, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGuteniev AlexGuteniev AlexGuteniev left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STL: Use normal for-loops when possible
6 participants
@babhishek21 @msftclas @BillyONeal @StephanTLavavej @CaseyCarter @AlexGuteniev