<atomic>: removing _ENABLE_ATOMIC_ALIGNMENT_FIX #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CaseyCarter
approved these changes
Apr 16, 2020
Yes. We figured this would be easiest for one of us with LLVM commit powers to fix after applying the local change. |
apenn-msft
approved these changes
Apr 16, 2020
I have the powers :), but never really touched anything in libcxx nor played with llvm on windows. It makes sense for someone else to commit it. |
StephanTLavavej
approved these changes
Apr 21, 2020
|
Thanks for this usability improvement, and congrats on your first microsoft/STL commit! 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #717
There is also a llvm test (
llvm-project/libcxx/test/support/msvc_stdlib_force_include.h) which defines_ENABLE_ATOMIC_ALIGNMENT_FIX. I guess that should be patched within llvm, right?