Implement ranges::subrange and ranges::view_interface #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Product changes: `<utility>`: declare `tuple`'s overloads of `std::get` so they are visible to the definition of `subrange`'s `_Pair_like` concept in `<xutility>`. `<xutility>`: Implementations of `subrange`, `view_interface`, and `borrowed_subrange_t`. Test changes: `std/include/range_algorithm_support.hpp`: Remove `iter_move` overload landmine for non-`indirectly_readable` `test_iterator`s that hampers detection. `std/tests/P0896R4_ranges_algorithm_machinery`: Enable `borrowed_subrange_t` smoke test. `std/tests/P0896R4_ranges_range_machinery`: Validate that `subrange` is a `borrowed_range`. `std/tests/P0896R4_ranges_subrange`: New test to cover `subrange` and `view_interface`.
Closed
BillyONeal
reviewed
Apr 21, 2020
miscco
reviewed
Apr 21, 2020
miscco
reviewed
Apr 21, 2020
StephanTLavavej
requested changes
Apr 21, 2020
CaseyCarter
commented
Apr 22, 2020
miscco
reviewed
Apr 22, 2020
StephanTLavavej
requested changes
Apr 23, 2020
StephanTLavavej
approved these changes
Apr 23, 2020
fengjixuchui
added a commit
to fengjixuchui/STL
that referenced
this pull request
Apr 25, 2020
Implement ranges::subrange and ranges::view_interface (microsoft#734)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product changes:
<xutility>: Implementations ofsubrange,view_interface, andborrowed_subrange_t.Test changes:
std/include/range_algorithm_support.hpp: Removeiter_moveoverload landmine for non-indirectly_readabletest_iterators that hampers detection.std/tests/P0896R4_ranges_algorithm_machinery: Enableborrowed_subrange_tsmoke test.std/tests/P0896R4_ranges_range_machinery: Validate thatsubrangeis aborrowed_range.std/tests/P0896R4_ranges_subrange: New test to coversubrangeandview_interface.